使用Spring Framework 时常犯的十大错误(小结)

@Getter
@Setter
@NoArgsConstructor
public class Bean implements Serializable {
  int firstBeanProperty;
  String secondBeanProperty;
}

public class Bean implements Serializable {
  private int firstBeanProperty;
  private String secondBeanProperty;

  public int getFirstBeanProperty() {
    return this.firstBeanProperty;
  }

  public String getSecondBeanProperty() {
    return this.secondBeanProperty;
  }

  public void setFirstBeanProperty(int firstBeanProperty) {
    this.firstBeanProperty = firstBeanProperty;
  }

  public void setSecondBeanProperty(String secondBeanProperty) {
    this.secondBeanProperty = secondBeanProperty;
  }

  public Bean() {
  }
}

@Entity
@NoArgsConstructor
@Getter
public class TopTalentEntity {

  @Id
  @GeneratedValue
  private Integer id;

  @Column
  private String name;

  public TopTalentEntity(String name) {
    this.name = name;
  }

}

@AllArgsConstructor
@NoArgsConstructor
@Getter
public class TopTalentData {
  private String name;
}

@RestController
public class TopTalentController {

  private final TopTalentRepository topTalentRepository;

  @RequestMapping("/toptal/get")
  public List<TopTalentData> getTopTalent() {
    return topTalentRepository.findAll()
        .stream()
        .map(this::entityToData)
        .collect(Collectors.toList());
  }

  private TopTalentData entityToData(TopTalentEntity topTalentEntity) {
    return new TopTalentData(topTalentEntity.getName());
  }

}

@RestController
@RequestMapping("/toptal")
@AllArgsConstructor
public class TopTalentController {

  private final TopTalentService topTalentService;

  @RequestMapping("/get")
  public List<TopTalentData> getTopTalent() {
    return topTalentService.getTopTalent();
  }
}

@AllArgsConstructor
@Service
public class TopTalentService {

  private final TopTalentRepository topTalentRepository;
  private final TopTalentEntityConverter topTalentEntityConverter;

  public List<TopTalentData> getTopTalent() {
    return topTalentRepository.findAll()
        .stream()
        .map(topTalentEntityConverter::toResponse)
        .collect(Collectors.toList());
  }
}

@Component
public class TopTalentEntityConverter {
  public TopTalentData toResponse(TopTalentEntity topTalentEntity) {
    return new TopTalentData(topTalentEntity.getName());
  }
}

@Value
public class ErrorResponse {

  private Integer errorCode;
  private String errorMessage;

}

@RequestMapping("/put")
public void addTopTalent(@RequestBody TopTalentData topTalentData) {
  boolean nameNonExistentOrHasInvalidLength =
      Optional.ofNullable(topTalentData)
     .map(TopTalentData::getName)
  .map(name -> name.length() == 10)
  .orElse(true);

  if (nameNonExistentOrInvalidLength) {
    // throw some exception
  }

  topTalentService.addTopTalent(topTalentData);
}

@RequestMapping("/put")
public void addTopTalent(@Valid @NotNull @RequestBody TopTalentData topTalentData) {
  topTalentService.addTopTalent(topTalentData);
}

@ExceptionHandler
@ResponseStatus(HttpStatus.BAD_REQUEST)
public ErrorResponse handleInvalidTopTalentDataException(MethodArgumentNotValidException methodArgumentNotValidException) {
  // handle validation exception
}

public class TopTalentData {
  @Length(min = 10, max = 10)
  @NotNull
  private String name;
}

@Target({ElementType.METHOD, ElementType.FIELD, ElementType.PARAMETER})
@Retention(RetentionPolicy.RUNTIME)
@Documented
@Constraint(validatedBy = { MyAnnotationValidator.class })
public @interface MyAnnotation {

  String message() default "String length does not match expected";

  Class<?>[] groups() default {};

  Class<? extends Payload>[] payload() default {};

  int value();

}

@Component
public class MyAnnotationValidator implements ConstraintValidator<MyAnnotation, String> {

  private int expectedLength;

  @Override
  public void initialize(MyAnnotation myAnnotation) {
    this.expectedLength = myAnnotation.value();
  }

  @Override
  public boolean isValid(String s, ConstraintValidatorContext constraintValidatorContext) {
    return s == null || s.length() == this.expectedLength;
  }
}

public class TopTalentData {
  @MyAnnotation(value = 10)
  @NotNull
  private String name;
}

@SpringBootApplication
public class Application {
  public static void main(String[] args) {
    SpringApplication.run(Application.class, args);
  }
}

# set default profile to 'dev'
spring.profiles.active: dev

# production database details
spring.datasource.url: 'jdbc:mysql://localhost:3306/toptal'
spring.datasource.username: root
spring.datasource.password:

spring.datasource.url: 'jdbc:h2:mem:'
spring.datasource.platform: h2

public class TopTalentController {

  private final TopTalentService topTalentService;

  public TopTalentController() {
    this.topTalentService = new TopTalentService();
  }
}

public class TopTalentController {

  private final TopTalentService topTalentService;

  public TopTalentController(TopTalentService topTalentService) {
    this.topTalentService = topTalentService;
  }
}

@Configuration
public class SampleUnitTestConfig {
  @Bean
  public TopTalentService topTalentService() {
    TopTalentService topTalentService = Mockito.mock(TopTalentService.class);
    Mockito.when(topTalentService.getTopTalent()).thenReturn(
        Stream.of("Mary", "Joel").map(TopTalentData::new).collect(Collectors.toList()));
    return topTalentService;
  }
}

@ContextConfiguration(classes = { SampleUnitTestConfig.class })

@RunWith(SpringJUnit4Cla***unner.class)
@ContextConfiguration(classes = {
    Application.class,
    SampleUnitTestConfig.class
})
public class RestAssuredTestDemonstration {

  @Autowired
  private TopTalentController topTalentController;

  @Test
  public void shouldGetMaryAndJoel() throws Exception {
    // given
    MockMvcRequestSpecification givenRestAssuredSpecification = RestAssuredMockMvc.given()
        .standaloneSetup(topTalentController);

    // when
    MockMvcResponse response = givenRestAssuredSpecification.when().get("/toptal/get");

    // then
    response.then().statusCode(200);
    response.then().body("name", hasItems("Mary", "Joel"));
  }

}